Rebuild for 0.8.14. #953
Rebuild for 0.8.14. #953
Conversation
|
The build fails with a version conflict on jQuery. This also happened in build 246465021. I don't know if the support/0.x branch would build before, but when I built it I resolved it with jQuery 2.x. Maybe this resolution should be marked in bower.json? |
|
@rhelgeby by all means update the bower resolution in this PR and I will accept it for sure, thanks for taking the time to help, I appreciate it :) |
Resolving as version 2.x because that's the version angular-schema-form depends on. If there's an issue with angular-ui-sortable, it the resolution should probably be increased to 3.x.
This was the original version conflict:
Unable to find a suitable version for jquery, please choose one by typing one of the numbers below:
1) jquery#~2.1.1 which resolved to 2.1.4 and is required by angular-schema-form
2) jquery#>=1.6 which resolved to 2.1.4 and is required by jquery-ui#1.12.1
3) jquery#>=1.7 which resolved to 2.1.4 and is required by pickadate#3.5.6
4) jquery#>=1.7.2 which resolved to 2.1.4 and is required by spectrum#1.7.0
5) jquery#>=3.1.x which resolved to 3.3.1 and is required by angular-ui-sortable#0.19.0
|
Thanks @rhelgeby let me know after a little while if you think it is stable enough for a release :) |
|
What about a release? |
|
We use this version in production already and I suppose it's considered stable now. I've forked and built my own version and reference my branch for this pull request directly: "angular-schema-form": "github:rhelgeby/angular-schema-form#build" Warning: You can reference my fork as a temporary workaround. But don't rely on me to keep this branch or fork forever. I won't give notices of changes. It's better to have an official release and package in the NPM repository. |
|
I have tested it and it works wonderful! Thank you! The only problem was the way to use it. I had to use this variant: This version should be in this repository as version |
|
Great. Even though I use this in production, again, remember that you use my fork on your own risk. I can't guarantee anything. If you want to ensure stability you could fork my clone and reference your own repository. @Anthropic Could you make an official release for 0.8.14 when time permits? It's best if we all switch to an official version. |
|
@rhelgeby I will, yes, glad it works for you all I will get onto it shortly, I'm recovering from surgery so there's been a slight delay in me getting to things as I am heavily medicated during recovery. |
|
@rhelgeby |
Description
Rebuild support/0.x so that the merge of pull request #906 is included in the build.
Even though it may not be ready for release, this allows other people to reference and test the support/0.x branch directly, using GitHub references in NPM's package.json.
Fixes Related issues
Checklist
@json-schema-form/angular-schema-form-lead